Repository navigation
feat: add channel_id and optional document_content to canvases.create - #2001
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2001 +/- ##
=======================================
Coverage 84.36% 84.37%
=======================================
Files 118 118
Lines 13800 13803 +3
=======================================
+ Hits 11643 11646 +3
Misses 2157 2157 ☔ View full report in Codecov by Harness. |
zimeg
marked this pull request as ready for review
October 28, 2026 17:13
mwbrooks
approved these changes
Oct 28, 2026
| "channel_id": channel_id, | ||
| } | ||
| ) | ||
| kwargs = _remove_none_values(kwargs) |
Member
There was a problem hiding this comment.
praise: Thanks for dropping the None values! title=None was going out as null in the JSON body before this.
Member
Author
|
@mwbrooks Thanks so much for the review! 🙏 ✨ |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request updates
canvases_createto match thecanvases.createarguments documented on docs.slack.dev:channel_idkeyword argument for the channel the canvas will be tabbed in. Before this change it could only be passed through**kwargs.document_contentoptional, since the docs list it as an optional argument.Nonevalues before sending the JSON body, so unset arguments likechannel_idandtitlearen't sent asnull.Testing
canvases:writescope and invite the bot to a channel.client.canvases_create(channel_id="C0123456789")withoutdocument_contentand confirm the response isokand an empty canvas shows up as a tab in that channel.client.canvases_create(title="Example", document_content={"type": "markdown", "markdown": "> standalone canvas!"})withoutchannel_idand confirm a standalone canvas is still created.Category
/docs(Documents)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.🤖 Generated with Claude Code