Repository navigation
Fix lock wakeups and context lifecycle cleanup - #100
Open
aidangarske wants to merge 11 commits into
Open
aidangarske wants to merge 11 commits into
aidangarske wants to merge 11 commits into
Conversation
…WNGRADE unlock path reachable and consistent
…wakeup per queued reader on unlock
…objects in wolfsentry_object_release instead of dereferencing NULL
…d try semantics in the ThreadX semaphore shims
…llocated context without an owned mutex
…hen its mutex cannot be taken in wolfsentry_context_clone
…eation clone its own fallthrough route
… initialized context when wolfsentry_init_ex fails
…init_ex when a duration conversion is rejected
…ree default policy copy in wolfsentry_context_exchange
…ventconfig field in the context lifecycle tests for C89 builds
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #100
Scan targets checked: wolfsentry-src, wolfsentry-bugs
Coverage: 1 of 2 in-scope changed file(s) opened by the reviewer; not opened: tests/unittests.c
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-10487- 2e8d03a - The AUTO_DOWNGRADE unlock path is now reachable and consistent.F-11600- 5e70b32 - Unlock now posts one reader wakeup per queued reader, so no waiting reader is stranded.F-8775- ffb4f55 - wolfsentry_object_release now rejects table-less objects instead of dereferencing NULL.F-8765- 252293c - The ThreadX semaphore shims now implement timed and try semantics.F-8750- 66387a2 - A partially allocated context is now freed without needing an owned mutex.F-10492- e8b7575 - wolfsentry_context_clone now frees the clone when its mutex cannot be taken.F-15470- 1ec0e5c - An as-at-creation clone now gets its own fallthrough route.F-11601- 8e6bba6 - wolfsentry_init_ex now frees a partially initialized context when it fails.F-10497- 756849c - wolfsentry_init_ex now fails when a duration conversion is rejected.F-6507- fcb7493 - wolfsentry_context_exchange now refreshes the lock-free copy of the default policy.