Repository navigation
ci: restore the automatic CDN purge on every push to main - #1653
Merged
Merged
Conversation
#1594 moved the webjs.dev purge from purge-cdn.yml to the merging machine, where ci-merge.sh started scripts/purge-cdn.sh in the background. That skipped silently whenever the shell lacked CLOUDFLARE_API_TOKEN or held an expired Railway login, and never ran for a merge done anywhere else; the purges for #1649 and #1651 both failed that way. CI is on Actions again and the repository secrets are still set, so the workflow's push trigger comes back unchanged. ci-merge.sh no longer starts a local purge, release.sh purges only with --purge, and purge-cdn.sh stays as the manual tool. Closes #1652
|
Preview for Next: fix the listed keys in the compose file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1652
What
.github/workflows/purge-cdn.ymlruns on every push tomainagain (plus manual dispatch). The workflow body is unchanged: it waits for the Railway deployment of the pushed sha and purges only onSUCCESS, so a docs-only push Railway skips stays green with no purge (ci: gate the CDN purge on the real Railway deployment status #1192).scripts/ci-merge.shno longer startsscripts/purge-cdn.shin the background; it prints where the purge runs.scripts/release.shpurges only with the new--purgeflag (replacing--no-purge), since the release commit's own push already runs the workflow.framework-dev.mdand therelease.ymlheader describe the automatic purge.Why
#1594 moved the purge to the merging machine. It skipped silently whenever that shell lacked
CLOUDFLARE_API_TOKENor held an expired Railway login, and never ran for a merge done anywhere else. The purges for #1649 and #1651 both failed that way. The repository secretsCLOUDFLARE_API_TOKENandRAILWAY_TOKENare still set.Tests
test/repo-health/purge-cdn-trigger.test.mjswith six assertions: the push trigger, the deploy lookup gated on push for the pushed sha, the purge and confirm steps gated on the deploy status, repository secrets, no local purge in ci-merge, and release.sh purging only on request.End-to-end proof
The merge commit of this PR is the first push the restored trigger sees. It touches only
.github,scripts,testand markdown, so Railway should skip the deploy and thePurge CDNrun should end green with a "no purge" notice. The next website merge after it is the first real purge.