Repository navigation
search_pypi_top: add --multiline option - #24
Open
StanFromIreland wants to merge 1 commit into
Open
StanFromIreland wants to merge 1 commit into
StanFromIreland wants to merge 1 commit into
Conversation
25 of 29 tasks
vstinner
reviewed
Oct 27, 2026
| yield from _grep_lines(archive_filename, filename, fp, regex) | ||
|
|
||
|
|
||
| def _grep_lines(archive_filename, filename, fp, regex): |
Owner
There was a problem hiding this comment.
If possible, I would prefer to not have to maintain two implementatons. Can't we just use _grep_multiline() in all cases (multiline or not)? Just inline _grep_multiline() again in grep().
Author
There was a problem hiding this comment.
It would slow down (by a noticeable amount) searches that could be done on a line by line basis, as such I opted to make it optional.
| if IGNORE_CYTHON and CYTHON_REGEX.match(data): | ||
| logger.info(f"ignore Cython file: {archive_filename}: {filename}") | ||
| return | ||
| last_start = -1 |
Owner
There was a problem hiding this comment.
Suggested change
| last_start = -1 | |
| last_start = None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It searches the whole file at once so the regex can match across lines. The regex is also compiled with
re.MULTILINE, and each line is reported at most once. This was helpful to me to gather data for a PEP I'm working on, as the idioms I was looking for spanned two or three lines.CC @hugovk @vstinner