Repository navigation
docs: async-boundary behaviors and custom-element JSX typing (#1667 rebased) - #1679
Merged
Merged
Conversation
- isPending: an errored expression is not pending; keep a plain read
under Errored (async reactivity, isPending reference).
- Errored: the fallback stays during a reset() retry; put Loading
outside with an `on` the retry changes (boundaries, async
reactivity, Errored reference).
- action: a rejected action promise from a handler does not reach
Errored; catch it in the generator or with .catch() (mutations,
action reference). Corrects the sentence that said it did.
- TypeScript: declare custom elements by augmenting @solidjs/web's
JSX.IntrinsicElements from a module .d.ts; add the missing
`export {}` to the web components example.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…reveals Per D-41: isPending is false once the error shows, not while it is staged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0117BoWPLXmEUSKddsQSHkzN
|
|
✅ Deploy Preview for solid-docs-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1667, rebased onto current v2-rebuild. It keeps Dev's first commit with its authorship, and it is on a solidjs branch because the fork can't take pushes from here.
concepts/mutations.mdx: both new Common problems sections were kept, "The save keeps running…" (from docs: from(), onFlush, hydration handoff, broadcast and other 2.0 gaps since rc.15 #1674) and "A failed action does not show theErroredfallback".from,FromSource,broadcastandsetStatefulProperty. docs: from(), onFlush, hydration handoff, broadcast and other 2.0 gaps since rc.15 #1674 already covers them, withfromunder Reactivity andbroadcastdocumented (it is not meant to be hidden).falseholds once the error shows.Checked against the signals rules on solid
next5e68925: D-24 and D-41 (isPending on errors), D-39 (the error fallback stays during areset()retry), D-14 and D-15 (onre-arm for the workaround), D-7 and theactionJSDoc (rejection goes to the caller's promise).pnpm lint:tone: 0 errors. The one warning is from upstream JSDoc.Co-authored-by: Dev Agrawal devagrawal09@gmail.com
Generated by Claude Code