Skip to content

fix(release): read Excel start dates, refuse impossible times and repeated columns, keep typed escapes, no suggestions for punctuation - #9545

Merged
waleedlatif1 merged 3 commits into
stagingfrom
fix/release-review-our-threads
Nov 1, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
fix/release-review-our-threads

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Fixes from the v0.9.39 release review for People, Sim Links and the extension:

  • People import, Excel dates: the workbook is read with cellNF: true, so a date cell keeps its number format and is converted from its stored value. Without it, dates formatted 1/31/24 or 31/01/2024 reached the server as display text and their whole row was skipped
  • People start dates: a time of day and offset must be real (T99:99, T24:00, +99:99 are refused) and a date uses one separator throughout (2024-01/31 is refused), instead of being accepted and dropped
  • People import columns: two headers that spell the same recognized column (Email and e-mail) are refused, instead of one being silently ignored
  • Sim Links suggestions: a typed name that is only punctuation suggests nothing (it used to fall through to the most-visited links); the prefix logic moved into a pure typedSimLinkPrefix in lib/sim-links/validation.ts
  • Extension sim keyword: an escape already typed (a%2Fb) is kept rather than encoded again, so the keyword resolves a value the same way the typed sim/ address does

Type of Change

  • Bug fix

Testing

  • lib/people/import.test.ts and lib/sim-links/destination.test.ts: 107 passing, with new cases that fail on the previous code (impossible times and mixed separators, repeated columns, punctuation-only prefixes)
  • Excel date handling verified by reading back generated workbooks with and without cellNF
  • Extension type-check; lint, check:api-validation:strict, check:boundaries, check:client-boundary, check:source-conventions, check:utils, check:comment-hygiene, check:test-patterns, check:unused-exports

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…eated columns, keep typed escapes, no suggestions for punctuation
@vercel

vercel Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 1, 2026 5:38am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no blocking issue was established.

Summary

The PR fixes People spreadsheet imports, rejects invalid dates and repeated headers, preserves typed URL escapes, and stops punctuation-only link suggestions.

  • People imports read Excel dates and stop on repeated column names.
  • People start dates reject mixed separators and impossible times.
  • People imports reject headers that name the same recognized field.
  • Punctuation-only Sim Link names return no suggestions.
  • The browser extension keeps percent-escapes already typed in Sim Link values.

Reviews (3) · Last reviewed commit: "fix(people): pass an out-of-range date s..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 8 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/lib/people/import.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 10 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 10 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit e407f28 into staging Nov 1, 2026
111 of 121 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/release-review-our-threads branch November 1, 2026 06:10

This branch was previously deployed

1 inactive deployment
Preview — 1f1dbcbe Deployed Nov 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant