Repository navigation
fix(release): read Excel start dates, refuse impossible times and repeated columns, keep typed escapes, no suggestions for punctuation - #9545
Conversation
…eated columns, keep typed escapes, no suggestions for punctuation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Medium impact] The PR appears safe to merge; no blocking issue was established. SummaryThe PR fixes People spreadsheet imports, rejects invalid dates and repeated headers, preserves typed URL escapes, and stops punctuation-only link suggestions.
Reviews (3) · Last reviewed commit: "fix(people): pass an out-of-range date s..." · Reviewed by Greptile |
There was a problem hiding this comment.
All reported issues were addressed across 8 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…th workbook tests
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 10 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
Fixes from the v0.9.39 release review for People, Sim Links and the extension:
cellNF: true, so a date cell keeps its number format and is converted from its stored value. Without it, dates formatted1/31/24or31/01/2024reached the server as display text and their whole row was skippedT99:99,T24:00,+99:99are refused) and a date uses one separator throughout (2024-01/31is refused), instead of being accepted and droppedEmailande-mail) are refused, instead of one being silently ignoredtypedSimLinkPrefixinlib/sim-links/validation.tssimkeyword: an escape already typed (a%2Fb) is kept rather than encoded again, so the keyword resolves a value the same way the typedsim/address doesType of Change
Testing
lib/people/import.test.tsandlib/sim-links/destination.test.ts: 107 passing, with new cases that fail on the previous code (impossible times and mixed separators, repeated columns, punctuation-only prefixes)cellNFcheck:api-validation:strict,check:boundaries,check:client-boundary,check:source-conventions,check:utils,check:comment-hygiene,check:test-patterns,check:unused-exportsChecklist
test-auditauthoring gate)