Repository navigation
Conversation
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
prerenderToNodeStreamreference saysonHeaders"receives a [Headers] instance". It doesn't. The Node.js stream API passes a plain object with aLinkproperty, the same asrenderToPipeableStream. Only the Web Streams APIs (prerender,renderToReadableStream) wrap the descriptor innew Headers(...).The source is
packages/react-dom/src/server/ReactDOMFizzStaticNode.js.prerenderToNodeStreamtypes the option asonHeaders?: (headers: HeadersDescriptor) => voidand passesoptions.onHeadersstraight through.prerenderin the same file is the one that callsonHeaders(new Headers(headersDescriptor)).The wrong sentence was copied from the Web Streams pages in #8632. This PR swaps in the wording
renderToPipeableStream.mdalready uses for the same callback.Code that follows the current docs and calls
headers.get('Link')throws aTypeError("headers.getis not a function").Test plan
Ran against published
react-dom@19.3.1on Node 24.9.0, with a component that callspreconnect('https://example.com'):yarn lint,yarn tsc,yarn lint-heading-idsandyarn deadlinkspass.