Repository navigation
Remove the target entry from texture docstrings - #2993
Merged
eruvanos merged 1 commit intoOct 30, 2026
Merged
Conversation
Texture2D, TextureArray and their OpenGL backends no longer accept a target argument, but their docstrings still listed it as "Ignored. Legacy". Passing target= raises TypeError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docstrings of
Texture2D,TextureArray,OpenGLTexture2DandOpenGLTextureArraylist atargetargument ("The texture type (Ignored. Legacy)"), but none of these constructors taketargetany more, and they have no**kwargs, sotarget=...raisesTypeError. This removes the stale entry from the four docstrings. No code changes.I found it with an automated comparison of docstring argument names against the constructor signatures, and checked that no texture constructor or
Context.texture()/texture_array()in the OpenGL and WebGL backends acceptstarget.