Repository navigation
Ignore collapsed children when sizing box layouts - #2990
Open
civilwarinfrance wants to merge 1 commit into
Open
civilwarinfrance wants to merge 1 commit into
civilwarinfrance wants to merge 1 commit into
Conversation
AI-assisted implementation and testing with OpenAI Codex.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2989. A
UIBoxLayoutwhose children all havevisible=NoneraisesValueErrorwhile finding their minimum size. With mixed children, it also reserves gaps for collapsed widgets and leaves unused space when allocating elastic children.Count only participating children in both sizing calculations, handle zero participants as an empty box, and invalidate the cached minimum when child visibility changes. Padding/borders and collapsed child rectangles are preserved.
visible=Falsekeeps its existing layout participation.Added 19 regression cases covering both orientations, empty/all-collapsed boxes, before/between/after positions, actual child geometry, padding/borders, hidden controls, dynamic changes and the real UIManager lifecycle. Original code fails 13 cases; the fixed cases all pass.
Validation on macOS ARM64/Python 3.14 with the lockfile's pytest/Ruff/Mypy versions and pinned Pyright:
AI assistance was used to identify, reproduce, implement and test this fix. The issue was opened before code changes, following the contribution guide.