Repository navigation
gh-161102: Fix idna incremental decoder after leading empty labels - #161103
Merged
Merged
Conversation
Count the separating dot for every label after the first, so dots after leading empty labels are not decoded again by the next call.
gpshead
added
needs backport to 3.14
gpshead
marked this pull request as ready for review
November 1, 2026 18:10
gpshead
enabled auto-merge (squash)
November 1, 2026 18:10
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-161129 is a backport of this pull request to the 3.14 branch. |
|
GH-161130 is a backport of this pull request to the 3.15 branch. |
gpshead
added a commit
that referenced
this pull request
Nov 1, 2026
gpshead
added a commit
that referenced
this pull request
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Count the separating dot in
IncrementalDecoder._buffer_decode()whenever a label has already been decoded (if result:, asCodec.encode()does), instead of whenever the byte count so far is non-zero, which is false after empty labels. Counting it beforeToUnicode()also makes theUnicodeDecodeErrorposition match the one-shot decoder. The encoder's identicalif size:test is left alone becauseToASCII()rejects empty labels.Fixes #161102
ANT-2026-KFX1PUWZ
idnaincremental decoder decodes dots twice after leading empty labels #161102