Skip to content

gh-160881: Fix test_is_python_process_non_python_subprocess with multicall sleep #160901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thomgree wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Open

gh-160881: Fix test_is_python_process_non_python_subprocess with multicall sleep #160901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Lib/test/test_profiling/test_sampling_profiler/test_children.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,14 @@ def reader():
return result[0]


def _wait_for_process_exec(proc, name, timeout):
def _wait_for_process_exec(proc, timeout):
# Wait until a child process calls exec() to replace the forked process
# executable. Raise AssertionError on timeout.
# executable. Don't check the executable name: it can be a multicall
# binary such as /bin/busybox. Raise AssertionError on timeout.
parent_exe = os.readlink("/proc/self/exe")
for _ in sleeping_retry(timeout, max_delay=0.1):
exe = os.readlink(f"/proc/{proc.pid}/exe")
if os.path.basename(exe) == name:
if exe != parent_exe:
break


Expand Down Expand Up @@ -625,7 +627,7 @@ def test_is_python_process_non_python_subprocess(self):
)

try:
_wait_for_process_exec(proc, "sleep", SHORT_TIMEOUT)
_wait_for_process_exec(proc, SHORT_TIMEOUT)

self.assertFalse(
is_python_process(proc.pid),
Expand Down
Loading