Repository navigation
Conversation
PartitionDefinition already lists STORAGE ENGINE as an option, but the lexer did not compose it into a single keyword. So STORAGE was taken as a new partition name, building e.g. `PARTITION ENGINE, PARTITION InnoDB`. Add STORAGE ENGINE to the compound keywords and regenerate the contexts. STORAGE ENGINE is only valid for partitions (and tablespaces), not as a table option, in all MySQL and MariaDB versions. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Maximilian Krög <maximilian.kroeg@geocept.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 5.11.x #685 +/- ##
============================================
- Coverage 96.51% 96.50% -0.01%
+ Complexity 2352 2341 -11
============================================
Files 71 71
Lines 5187 5179 -8
============================================
- Hits 5006 4998 -8
Misses 181 181
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PartitionDefinition already lists
STORAGE ENGINEas an option, but the lexer did not compose it into a single keyword. So STORAGE was taken as a new partition name, building e.g.PARTITION ENGINE, PARTITION InnoDB.Add
STORAGE ENGINEto the compound keywords and regenerate the contexts.STORAGE ENGINEis only valid for partitions (and tablespaces), not as a table option, in all MySQL and MariaDB versions.