Repository navigation
Reject negative lengths in Bit.from_binary - #173
Closed
beyondsundial wants to merge 1 commit into
Closed
beyondsundial wants to merge 1 commit into
beyondsundial wants to merge 1 commit into
Conversation
Member
|
Thanks @beyondsundial, merged a version of this in the commit above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject a negative bit length before constructing a Bit from binary data. With an empty payload, lengths -1 through -7 currently pass the byte-count check because (length + 7) // 8 is zero.
Add negative-length regression cases and round-trip controls at lengths 0, 1, 7, 8 and 9.
Validation: 75 Bit/vector/half-vector/sparse-vector tests passed; mypy for the changed files and git diff --check passed. Three new negative-length cases fail on the unchanged upstream baseline. PostgreSQL/driver integration tests and the full CI matrix were not run.