Repository navigation
fix(auth): send auth challenge without error when no token is present - #3779
Jihaochang1 wants to merge 1 commit into
Conversation
|
This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3769. If a maintainer assigns you to #3769, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take. You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way. CONTRIBUTING.md has the full reasoning, but in short:
Maintainers: reopen, remove |
Per RFC 6750 §3.1, when a request lacks any authentication, the resource server SHOULD NOT include an error code. The current code returns error="invalid_token" for both missing and invalid tokens, which prevents clients from distinguishing between the two cases. This change: - Detects whether an Authorization header was present - For missing credentials: returns challenge with resource_metadata and scope (no error code) - For invalid credentials: keeps the existing invalid_token response Fixes modelcontextprotocol#3769
Summary
Per RFC 6750 §3.1, when a request lacks any authentication, the resource server SHOULD NOT include an error code. The current code returns
error="invalid_token"for both missing and invalid tokens, preventing clients from distinguishing between the two cases.Changes
resource_metadataandscope(no error code)invalid_tokenresponseReferences
Fixes #3769