Skip to content

chore(button): update snapshots for the subtle hue - #31656

Open
thetaPC wants to merge 31 commits into
FW-6838-huefrom
FW-6838-hue-snapshots
Open

chore(button): update snapshots for the subtle hue#31656
thetaPC wants to merge 31 commits into
FW-6838-huefrom
FW-6838-hue-snapshots

Conversation

@thetaPC

@thetaPC thetaPC commented Oct 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Issue number: resolves internal

What is the current behavior?

The new button hue page has no baselines.

What is the new behavior?

  • Adds the hue page's baselines in ios, md and ionic
  • md and ios outline labels are darker, and so are focused ios clear buttons with a color, from the foreground change in feat(button): add the subtle hue #31649

Any other difference is a regression.

Does this introduce a breaking change?

  • Yes
  • No

@thetaPC
thetaPC added this pull request to stack #31629 October 26, 2026 17:48
@vercel

vercel Bot commented Oct 26, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ionic-framework Ready Ready Preview Oct 29, 2026 6:29pm UTC

Request Review

@github-actions github-actions Bot added the package: core @ionic/core package label Oct 26, 2026
@thetaPC thetaPC mentioned this pull request Oct 26, 2026
Open
1 of 2 tasks
@thetaPC
thetaPC removed this pull request from stack #31629 October 28, 2026 22:48
@thetaPC
thetaPC added this pull request to stack #31667 October 28, 2026 22:54
@thetaPC
thetaPC marked this pull request as ready for review October 29, 2026 16:03
@thetaPC
thetaPC requested a review from a team as a code owner October 29, 2026 16:03
@thetaPC
thetaPC requested a review from ShaneK October 29, 2026 16:03
thetaPC and others added 2 commits October 29, 2026 11:21
@thetaPC
Merge remote-tracking branch 'origin/FW-6838-hue' into FW-6838-hue-sn…
66a2d8f 
…apshots

# Conflicts:
#	core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-md-ltr-Mobile-Chrome-linux.png
#	core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-md-ltr-Mobile-Firefox-linux.png
#	core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-md-ltr-Mobile-Safari-linux.png
#	core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-md-rtl-Mobile-Chrome-linux.png
#	core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-md-rtl-Mobile-Firefox-linux.png
#	core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-md-rtl-Mobile-Safari-linux.png
@Ionitron
chore(): add updated snapshots
9a1fbb2

This branch was successfully deployed

1 active deployment
Preview — 9a1fbb20 Deployed Oct 29, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShaneK ShaneK Awaiting requested review from ShaneK ShaneK is a code owner automatically assigned from ionic-team/framework

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

package: core @ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thetaPC @Ionitron