You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Speeds up global npm installation by moving build tools to development dependencies and upgrading oclif. Preserves existing table options, hidden token input, and fish completion.
Validation: build, lint, unit and smoke tests, plus isolated npm installs with and without --ignore-scripts.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
The column resolver matches only display headers, so table flags using property names can drop columns, throw filter errors, or silently ignore sorting.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Add root help and version flags to Fish completion
src/autocomplete.ts:32
Register the root help and version flags in the generated Fish completion. Every flag entry generated below requires a command path, so hackmd-cli --<TAB> cannot suggest --help or --version, and their short forms are missing too. These are supported entry points configured in package.json and checked by the smoke tests; add root-scoped completion entries for them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #120
Speeds up global npm installation by moving build tools to development dependencies and upgrading oclif. Preserves existing table options, hidden token input, and fish completion.
Validation: build, lint, unit and smoke tests, plus isolated npm installs with and without
--ignore-scripts.