Repository navigation
fix: enable Escape to close execution details in embedded pages - #1426
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deployed component library disables Escape dismissal by default, so the execution details drawer stays open when SQLBot is embedded in an iframe. Explicitly enable
close-on-press-escapeinExecutionDetails.vueso this behavior no longer depends on the library default.Validation: four local browser regression scenarios passed across standalone and cross-origin iframe pages with both library defaults, including reopening and the close button. ESLint and Vue/TypeScript checks passed. The full build was blocked by existing filesystem write permissions. Local test fixtures and configuration changes are intentionally excluded from this PR.