Skip to content

Use --release 8 to compile the main class. - #9765

Open
lahodaj wants to merge 1 commit into
apache:masterfrom
lahodaj:main-use-release-8
Open

lahodaj wants to merge 1 commit into
apache:masterfrom
lahodaj:main-use-release-8

Conversation

@lahodaj

@lahodaj lahodaj commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

The base Main class is rebuilt to run on JDK 8 - but the build (still) uses -source 8 -target 8. Not sure if there's a reason for it, or if it can be replace with --release 8 (i.e. release="8" in ant)?


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

LLMs, Commit messages and PR description:

  • Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.
  • LLM assisted commits should be attributed with an Assisted-by: MODEL_NAME MODEL_VERSION line appended to the commit message.
    • Please mention coding assistance in the PR description too (eg. by adding the same Assisted-by line from above)
    • Please describe the changes in your own words - we'd like to know you understand the changes being made!

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

@lahodaj lahodaj added this to the NB33 milestone Oct 29, 2026
@lahodaj
lahodaj requested a review from mbien October 29, 2026 15:14
@lahodaj lahodaj added the Platform [ci] enable platform tests (platform/*) label Oct 29, 2026

@mbien mbien left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

I think there once was a reason for doing it like that but can't remember atm. (something didn't like the value 8 for jdk 8 specifically)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Platform [ci] enable platform tests (platform/*)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants