Repository navigation
Pin architecture-specific wheels for extractcode and libmagic - #2488
Open
Anurag-S1ngh wants to merge 1 commit into
Open
Anurag-S1ngh wants to merge 1 commit into
Anurag-S1ngh wants to merge 1 commit into
Conversation
The 16.5.210531 and 3.5.1.210531 extractcode releases publish only x86_64 and Windows wheels, and 5.39.210531 does the same for typecode-libmagic. The 16.5.210525 and 3.5.1.210525 releases publish only arm64 and aarch64 wheels, so a single pin cannot work on both architectures and docker compose build fails on Apple Silicon. Select the arm64 pins with platform markers and keep the existing x86_64/Windows pins for every other machine. Signed-off-by: Anurag Singh <anuragsingh2313@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker compose buildfails on Apple Silicon withResolutionImpossiblebecause the pinnedextractcode-7z,extractcode-libarchive, andtypecode-libmagicreleases publish architecture-exclusive wheels. The.210531releases are x86_64/Windows only, and the arm64/aarch64 builds live in.210525for extractcode and.210223for typecode-libmagic, so a single pin cannot cover both.Changes
requirements.txtandrequirements-dev.txtwith platform-conditional pins.extractcode-7z==16.5.210525,extractcode-libarchive==3.5.1.210525, andtypecode-libmagic==5.39.210223.16.5.210531,3.5.1.210531, and5.39.210531pins.Testing
docker compose build vulnerablecodecompletes on Apple Silicon (arm64) with this change. Before the change it failed at the pip step withResolutionImpossible.arm64,aarch64,x86_64, andAMD64; each selects the expected version.pip download --only-binary=:all:on arm64 fetches the three arm64 wheels.python:3.12, resolving the same three arm64 versions.Closes #2426