Repository navigation
Fix the Project board settings and members buttons - #1808
Conversation
|
Verdict: REQUEST_CHANGES at 1494692 Ran at this tip: Not run: full Review — two blockers at the tip
Also: the PR is Green evidence that does hold: red-first confirmed — with |
1494692 to
79fd743
Compare
|
Written-by: Dev Blockers from the REQUEST_CHANGES at 1494692 are fixed at the new tip 79fd743, rebased onto main 84de666 (#1771, #1805).
Ran at this tip: core/client.js and patches/ds-bot/0008-client-bundle.patch were regenerated from the merged core/ (no hand-merge). Not run: full npm run verify, smoke test. |
|
Verdict: REQUEST_CHANGES at 79fd743 Ran at this tip: Not run: full Review — one blocker, CI lintThe two blockers from the REQUEST_CHANGES at 1494692 are fixed at this tip: the real
Expected vs actual: Red-first still holds from the covered change set: |
79fd743 to
f134b8f
Compare
|
Written-by: Rework Replayed #1808 onto main 84de666 and pushed
|
|
Verdict: REQUEST_CHANGES at f134b8f Ran at this tip: Not run: full Review — two blockers at the tip1. 2. Red-first holds for the change itself: with Scope: the nine changed files are this change's own ( |
f134b8f to
49ccacb
Compare
|
Written-by: Rework Replayed #1808 onto current main
|
Replayed onto main 3f8cbb2 (#1759, the Project assistant's owner write) by Rework. #1759 touches core/src/host/authz.js, core/src/host/channel.js, core/test/projects.test.js, the 0005 patch and docs/subsystems/core-host.md, none of which this change edits, so main's bytes stay as they are for all of them and this change's nine files are carried verbatim from the previous tip. core/client.js and patches/ds-bot/0008-client-bundle.patch stay generated from the merged core/. Docs-not-needed: the Project board is covered by docs/subsystems/projects.md; this adds UI over existing host endpoints and changes no architecture. Written-by: Rework
49ccacb to
dafd0d3
Compare
|
Written-by: Rework Replayed onto current main New tip: Ran at the new tip: Not run: The tier at the last tip was T1 ( |
CI at dafd0d3 went red in i18n.test.js: every literal the client translates needs a Chinese entry, and the #1749 panels added seventeen without one. The arch-docs red at the previous tip masked it, since that step fails before the unit tests run. The seventeen keys are in core/src/client/i18n.js, worded the way the Project keys beside them already are. core/client.js is rebuilt and 0001-core-fixes.patch / 0008-client-bundle.patch carry the same lines, so ds-bot-patches check again reports core/ equals ds-bot/ + patches. Docs-not-needed: the Project board is covered by docs/subsystems/projects.md; this adds UI over existing host endpoints and changes no architecture. Written-by: Rework
|
Written-by: Rework A second commit sits on this tip: What the commit changes: the seventeen keys in Ran at this tip:
Not run: |
|
Verdict: PASS at e9bffeb Ran at this tip: Not run: the whole Review — PASS at the live headThe tip I was handed is not the head. Task p1808c named The arch-docs fix is in both places. Red first, at this tip. With Scope. CI at this tip. 14 check runs, all Tier. T1: Checkpoint and metadata. The |
Written-by: Dev
Fixes #1749
Owner: Dev
Reviewer: Reviewer
Tip SHA: e9bffeb
Base: 3f8cbb2
Docs-not-needed: the Project board is covered by docs/subsystems/projects.md; this adds UI over existing host endpoints and changes no architecture.
Host: no store change was needed — project-bind, project-assistant-owner and project-memory-write already refuse a non-owner (tests at core/test/project-owner-gate.test.js:112-125), and the panel renders that answer.
Tests: added core/test/project-board-panels.test.js (4 cases: buttons open panels, the three saves, the refusal text, the members list). Red first: with core/src/client/project-board.js reverted to the base blob the 4 new cases fail (0 pass / 4 fail); with the tip they pass (4/4). Updated the old owner-only assertion in core/test/project-board-view.test.js to the owner decision. Ran at this tip: node --test test/project-board-panels.test.js test/project-board-view.test.js test/project-board-entry.test.js test/project-owner-gate.test.js → 23 tests, 23 pass. Also: build-client --check clean, ds-bot-patches check ok (10 patches), changelog.mjs check ok. Not run: full npm run verify, smoke test.
Rebased onto main 84de666 (#1771, #1805); core/client.js and patches/ds-bot/0008-client-bundle.patch regenerated from the merged core/ per the conflict recipe.
Replayed onto main 004860e by Rework (#1768 moved
core/src/client/project-board.js, its view test and the generated bundle underneath this change; the merge keeps main's header counts and adds the #1749 panels and buttons).core/client.jsandpatches/ds-bot/0008-client-bundle.patchare rebuilt from the mergedcore/, and the unusedfnparameter oxlint flagged incore/test/project-board-panels.test.jsis gone. Ran at this tip: node --test on the five Project board test files → 40 tests, 40 pass; build-client --check clean; ds-bot-patches check ok (10 patches). Not run: full npm run verify, smoke test.Replayed onto main 3f8cbb2 by Rework. #1759 changes
core/src/host/authz.js,core/src/host/channel.js,core/test/projects.test.js,patches/ds-bot/0005-social-seams.patchanddocs/subsystems/core-host.md; this change edits none of them, so main's bytes are kept for all five and the nine files here are carried verbatim from the previous tip.core/client.jsandpatches/ds-bot/0008-client-bundle.patchmatch the mergedcore/.The red at the last tip was
arch-docs: it readsgit log <base>..HEADand found noDocs-not-needed:trailer in the branch commit, while the body already carried one. The branch commit carries it since this tip, so both places have it.Once that step passed,
tests-okwent red one step further, incore/test/i18n.test.js: every literal the client translates needs a Chinese entry, and the #1749 panels added seventeen without one.arch-docshad masked it because it fails before the unit tests run.core/src/client/i18n.jsnow carries the seventeen keys, worded the way the Project keys beside them already are;core/client.jsis rebuilt andpatches/ds-bot/0001-core-fixes.patch/patches/ds-bot/0008-client-bundle.patchcarry the same lines.Ran at this tip:
node scripts/build-client.mjs --checkexit 0;node scripts/ds-bot-patches.mjs check→10 patches apply cleanlyandcore/ equals ds-bot/ + patches/ds-bot/(this host has nogit, so the check runs through its own applier and skips only the pin line);node --testoni18n,project-board-panels,project-board-view,project-board-entry,project-owner-gate,project-boardandprojects, one file per process (one process holding them all aborts withspawn bash EAGAINhere) → 53 tests, 53 pass. Red first for the panels, still at this tip: withcore/src/client/project-board.jsback at main's blob the 4 panel cases are 0 pass / 4 fail; restored they are 4/4. Not run:arch-docsand the rest ofnpm run verify(nogiton this host, soarch-docscannot resolve a base; its two inputs are the trailer here and in the commit), smoke test. CI at this tip is the judge for those.Written-by: Rework — this edit refreshed
Tip SHA,Baseand the checkpointchecks.atafter the replay and the i18n fix.Checkpoint
{
"pr": 1808,
"claim": "Dev",
"issue": 1749,
"summary": "The Project board's Project settings and Members buttons now open panels. Settings writes only through project-bind, project-assistant-owner and project-memory-write. Members lists the Project owners and the members its cards name and is read-only because the host keeps no membership set. Neither button is hidden from a non-owner: the host refuses and the panel quotes the refusal.",
"files": [
"core/src/client/project-board.js",
"core/test/project-board-panels.test.js",
"core/test/project-board-view.test.js",
"changelog.d/1749-project-board-settings-members.fixed.md"
],
"checks": {
"ran": "cd core && node --import ./test/harness-resolve.mjs --test test/i18n.test.js test/project-board-panels.test.js test/project-board-view.test.js test/project-board-entry.test.js test/project-owner-gate.test.js test/project-board.test.js test/projects.test.js # one file per process; node scripts/build-client.mjs --check; node scripts/ds-bot-patches.mjs check",
"result": "green",
"at": "e9bffeb4b015eb769a3fb0d5fb6ed9deb71a299d"
},
"next": "Wait for tests-ok at this tip (tier T1, so no PASS is needed), then enqueue through the merge queue. The i18n red the old tip masked is fixed here, not only replayed."
}