Skip to content

Add greeting feature - #15669

Open
192421296simats-tech wants to merge 4 commits into
TheAlgorithms:masterfrom
192421296simats-tech:feature-update
Open

192421296simats-tech wants to merge 4 commits into
TheAlgorithms:masterfrom
192421296simats-tech:feature-update

Conversation

@192421296simats-tech

Copy link
Copy Markdown

Describe your change

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests?
  • Documentation change?

Added a new Python file named greeting.py containing a greet() function that returns a greeting message. The program demonstrates a basic Python function and prints the greeting for a sample name.

Checklist

  • I have read [CONTRIBUTING.md](https://github.com/TheAlgorithms/Python/blob/master/CONTRIBUTING.md).
  • This pull request is my own work — I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file.
  • All new Python files are placed inside an existing directory.
  • All filenames are in lowercase characters.
  • All function and variable names follow Python naming conventions.
  • All functions and variable names have appropriate type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL explaining the algorithm.
  • This pull request resolves an existing issue.

@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Oct 29, 2026

@algorithms-keeper algorithms-keeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment thread greeting.py Outdated
@@ -0,0 +1,4 @@
def greet(name):

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: greet. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: name

As there is no test file in this pull request nor any test function or class in the file greeting.py, please provide doctest for the function greet

@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Oct 29, 2026
@algorithms-keeper algorithms-keeper Bot removed require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Oct 29, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant