Repository navigation
fix(sorts): handle small arrays in FlashSort and empty arrays in DutchNationalFlagSort - #7662
Merged
alxkm merged 2 commits intoOct 27, 2026
Conversation
…hNationalFlagSort
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7662 +/- ##
============================================
- Coverage 82.23% 82.22% -0.01%
+ Complexity 8400 8399 -1
============================================
Files 843 843
Lines 26138 26140 +2
Branches 5098 5098
============================================
Hits 21494 21494
Misses 3853 3853
- Partials 791 793 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Rishavbhattarai
marked this pull request as ready for review
October 27, 2026 03:09
Rishavbhattarai
requested review from
DenizAltunkapan,
alxkm and
yanglbme
as code owners
October 27, 2026 03:09
alxkm
approved these changes
Oct 27, 2026
alxkm
left a comment
Member
There was a problem hiding this comment.
Looks good. Thank you for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two crashes on small inputs:
FlashSortsizes its class table as(int) (classificationRatio * n). With the default ratio 0.45 that is 0 for any 2-element array, sosort({2, 1})throwsArrayIndexOutOfBoundsException. Any ratio and length with a product below 1 does the same, for example ratio 0.1 with 5 elements. The fix uses at least one class.DutchNationalFlagSort.sort(T[])readsarray[ceil(n / 2) - 1]to pick the middle value, which is index -1 for an empty array. It now returns the empty array right away.A regression test for each. Both fail on
master.clang-format -i --style=file path/to/your/file.java