Repository navigation
fix: find tables in SET values instead of throwing - #2873
Merged
manticore-projects merged 1 commit intoOct 29, 2026
Merged
manticore-projects merged 1 commit into
manticore-projects merged 1 commit into
Conversation
TablesNamesFinder threw UnsupportedOperationException for every SET statement except SQL Server ON/OFF options. A MySQL trigger whose body is or contains SET, such as FOR EACH ROW SET NEW.a = ..., failed the same way, although its table is known. The finder now visits the value expressions of each assignment, so a subquery in a SET value reports its tables and other SET statements report none. Signed-off-by: minleejae <mmj9808@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TablesNamesFinderthrewUnsupportedOperationExceptionfor everySETstatement except the SQL ServerON/OFFoptions. A subquery in a value, as inSET @a = (SELECT MAX(id) FROM t1), was never reached. A MySQL trigger whose body is or containsSET, such asCREATE TRIGGER trg BEFORE INSERT ON t1 FOR EACH ROW SET NEW.a = …, failed the same way, although its table is known. The trigger examples in the MySQL manual use this form.The finder now visits the value expressions of each assignment, as it does for the values of
UPDATE … SET. A subquery in aSETvalue reports its tables, and otherSETstatements report none. The deliberateUnsupportedOperationExceptionfor other statements, such asCREATE SYNONYM, is unchanged.Public method signatures are retained.
Syntax reference: MySQL 8.4 SET for variables, trigger syntax.
Validation:
TablesNamesFinderTestadds aSETwith a subquery, aSETwithout tables and two MySQL triggers, one with aSETbody and one withSETinsideBEGIN … END. Both new tests fail on masterc84ad0ebcwithUnsupportedOperationException: Finding tables from SetStatement is not supported.SETstatement.check: 12,264 tests, 0 failures, 25 skipped. Grammar ambiguity, formatting (Spotless ratchet againstupstream/master), Checkstyle, PMD, SpotBugs and JaCoCo pass. The grammar is unchanged.AI assistance: prepared with Claude Code.