Repository navigation
fix: validate INTO OUTFILE, DUMPFILE and INTO TEMP as selectInto - #2868
Merged
manticore-projects merged 1 commit intoOct 29, 2026
Merged
manticore-projects merged 1 commit into
manticore-projects merged 1 commit into
Conversation
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FeaturesAllowed.SELECTis documented as every SELECT feature "without modification features likeselectInto", andValidationwith it is a natural gate for only letting read queries through.SelectValidatorchecksgetIntoTables()againstFeature.selectInto, but the MySQL/MariaDBINTO OUTFILE/INTO DUMPFILE/INTO @varclause lives ingetMySqlSelectIntoClause()and the trailingINTO TEMPtable ingetIntoTempTable(), and neither was looked at. SoSELECT * INTO newtab FROM tis reported asselectInto not allowed, whileSELECT a FROM t INTO OUTFILE '/tmp/x',SELECT '<?php ... ?>' INTO DUMPFILE '/var/www/html/s.php'and the same clause inside anIN (...)subquery validate with no errors, although they write files on the database server. I found it by running statements with side effects throughValidation.validate(List.of(FeaturesAllowed.SELECT), sql)and comparing which ones came back clean. Both clauses now reportselectIntonext to the existing INTO-table check, andselectIntois added toMySqlVersionandMariaDbVersionso validating againstDatabaseType.MYSQL/MARIADBstill accepts their ownSELECT ... INTOsyntax. The new parameterized case inSelectValidatorTestfails for all five statements before the change, and./gradlew checkpasses after it.