Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
C extends B implements A, member resolution can selectA's method even whenBsupplies an implementation with a narrower return type. For example, an interface returningFoohides an inherited method returning the subtypeBar.Prefer a public class declaration over an earlier interface declaration with the same method key. Resolve its return and argument types in the class's generic context, while retaining the existing hierarchy order and inheritable annotation priority. Direct annotations and mix-in overrides are applied to the selected declaration.
Fixes #57.
Added 18 tests covering covariant and generic returns, direct overrides, default and abstract methods, filtering, and method/parameter annotations. The same tests give 13 failures and 5 passing controls on the original code, then all pass with the fix.
./mvnw clean verifypasses on OpenJDK 17.0.20 with the wrapper's Maven 3.9.11: 375 tests, no failures, errors or skips. This includes packaging, module metadata, coverage and Javadoc generation; the POM and Java 8 source/target settings are unchanged.