Repository navigation
Drop deprecated Microsoft.SourceLink.GitHub 8.0.0 (CVE-2026-62900) - #1122
Merged
FlorianRappl merged 1 commit intoOct 27, 2026
Merged
Conversation
DYH1319
marked this pull request as ready for review
October 27, 2026 15:38
pr-comment: Run #155
🎉 All tests passed!Github Test Reporter by CTRF 💚 |
SourceLink is built into the .NET SDK since .NET 8; the package is deprecated and pins vulnerable Microsoft.Build.Tasks.Git 8.0.0 (CVE-2026-62900 / GHSA-23fw-v26w-5fgq). PublishRepositoryUrl=true in common.props keeps built-in SourceLink active.
DYH1319
force-pushed
the
fix/drop-deprecated-sourcelink
branch
from
October 27, 2026 15:39
24dcca0 to
a7f14ff
Compare
DYH1319
marked this pull request as draft
October 27, 2026 15:39
DYH1319
marked this pull request as ready for review
October 27, 2026 15:41
FlorianRappl
approved these changes
Oct 27, 2026
FlorianRappl
left a comment
FlorianRappl
left a comment
Collaborator
There was a problem hiding this comment.
LGTM - imho we can safely do that without any side-effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
Microsoft.SourceLink.GitHub8.0.0 fromElectronNET.APIandElectronNET.AspNet.The package transitively depends on
Microsoft.Build.Tasks.Git8.0.0, which has a known vulnerability — CVE-2026-62900 / GHSA-23fw-v26w-5fgq (.NET Information Disclosure, CVSS 5.9). Per the advisory, the 8.0.0 package line has no patched NuGet version.The fix is safe because the package is deprecated anyway: SourceLink has been built into the .NET SDK since .NET 8. With
PublishRepositoryUrl=truealready set incommon.props, the SDK's built-in SourceLink continues to embed repository/commit metadata (e.g.+commitshainInformationalVersion) without any package reference — verified locally onnet10.0builds.Test plan
dotnet build— NU1902 warning eliminatedAssemblyInformationalVersionstill carries+<commit>suffix (built-in SourceLink active)