Repository navigation
Reject TOML integers outside the safe integer range - #10019
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: f5bb745 The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
Contributor
Author
|
Could also do Instead of adding the helper function |
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toml.parse("id = 9007199254740993")silently returns9007199254740992. Reject integer tokens outside JavaScript's safe integer range through the parser's existing error path. Decimal, hexadecimal, octal and binary integers now share one conversion and range check; floating-point syntax keeps its existing behavior. This deliberately applies a conservative range limit, including to exactly representable integers aboveNumber.MAX_SAFE_INTEGER.The TOML integer specification requires an error when an integer cannot be represented losslessly. The existing numeric-format test is extended with the signed safe boundaries, a large float, and 2^53 in every integer radix (plus its negative decimal).
Validation: all 17 upstream TOML tests,
pnpm lint-fix, andpnpm checkpass. External conformance and bounded properties on Node 22/24/26 resolve all eight integer-related failures per runtime with no new failures. The external suite still has 66 failures per runtime in other known TOML categories.Closes EFF-3023