Manchester |26-ITP-Sep | Precious Moses | Sprint 1 | Data Groups by moses77-boop · Pull Request #1479 · CodeYourFuture/Module-Data-Groups

moses77-boop · 2026-10-23T19:16:14Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1071

Changelist

In this PR, I refactored codes, implemented functions and test codes to complete the coursework.

… negative values

…ve numbers

…n array of numbers

…recision

…tion

… typo

…justments

…tion

cjyuan · 2026-10-31T00:34:47Z

+test("given a value that is not an array, throws an error", () => {
+    expect(() => calculateMean("banana")).toThrow("calculateMean requires an array of numbers");
+});
+
+test("given a value that is not an array, throws an error", () => {
+    expect(() => calculateMean(42)).toThrow("calculateMean requires an array of numbers");
+});
+
+test("given a value that is not an array, throws an error", () => {
+    expect(() => calculateMean(null)).toThrow("calculateMean requires an array of numbers");
+});
+
+test("given a value that is not an array, throws an error", () => {
+    expect(() => calculateMean({})).toThrow("calculateMean requires an array of numbers");
+});


Could consider grouping these test cases into one category; they have the same test description.

Code refactored.

cjyuan · 2026-10-31T00:37:41Z

@@ -0,0 +1,19 @@
+const fs = require("fs");
+const input = fs.readFileSync("input.txt", "utf8");
+const changes = input.trim().split("\n").map(Number);


Could you explain why you choose to apply .trim() to the input before applying split()?

.trim() removes the trailing newline so I don't get an empty last entry.

Note: For large file, calling trim() just to remove the trailing newline is not efficient. Do you know why?

No change needed.

cjyuan · 2026-10-31T00:43:33Z

+while (true) {
+  for (const change of changes) {
+    frequency += change;
+    if (seen.has(frequency)) {
+      console.log(frequency);
+      process.exit(0);
+    }
+    seen.add(frequency);
+  }
+}


Is this implementation for the second part of the problem? I think the first part is just adding all the frequencies.

I actually wrote the part 1 first and refactored the same code for part 2.
Do I need to write both parts of the code separately?

No need. Knowing how to read lines of data from a file is more important in this exercise.

cjyuan · 2026-10-31T00:47:10Z

+    let total = 0;
+
+    for (const element of elements) {
+        if (typeof element !== "number") {


Note: NaN and positive/negative Infinity are also value of type numbers. If it is up to you, how would you design the function when the given array contain such values?

I have refactored the code.

cjyuan · 2026-10-31T00:48:06Z

+    if (list.length === 0) {
+        throw new Error("calculateMean requires a non-empty array");
+    }
+


Spacing a bit inconsistent after if.

…unction

cjyuan · 2026-10-31T15:46:46Z

Changes look good. Well done.

cjyuan · 2026-10-31T15:47:28Z

Note: You should also change the label to "Needs review" after you have made all the changes.

moses77-boop added 30 commits October 22, 2026 00:51

Fix median calculation to return correct value from the list

09fe065

Fix median calculation to handle both odd and even length lists

1fde0e0

Fix median calculation to use sorted list

ecfa4aa

Add error handling for input validation to calculateMedian function

fd8ec66

Add error handling for empty array

e3e6ea5

Add error handling to ensure all elements in the array are numbers

e95631c

Implement test for empty array case in findMax function

bba68b6

Add input validation to findMax function to ensure an array is provided

66a3e6a

Refactor findMax function to include max initialization

ed01080

Add test for single number array case in findMax function

b564d44

Refactor findMax function

f104afb

Add test for non-number input in findMax function

b6f529d

Add test for non-array inputs in findMax function

c7b0e6e

Add test for finding the maximum number in an array with positive and…

872a29b

… negative values

Add test for finding the closest number to zero in an array of negati…

6db3742

…ve numbers

Add test for finding the largest decimal number in an array

82f5c3a

Add test for handling non-number elements in sum function

7aaff3c

Add error handling for non-array inputs in sum function

02c2e87

Implement test for returning 0 when given an empty array in sum function

44bf4cf

Refactor sum function to improve error handling and ensure input is a…

0a3d100

…n array of numbers

Add test for handling non-array inputs in sum function

5506d62

Add test for handling single number input in sum function

1507d42

Add test for handling negative numbers in sum function

cc8664c

Add test for handling decimal numbers in sum function

c229437

Fix test for decimal numbers in sum function to use toBeCloseTo for p…

6b578bf

…recision

Fix test for decimal numbers in sum function to return correct total

4b21f36

Implement export command for dedupe function

6fc8984

Implement test for dedupe function to handle empty array case

fb39a6b

Implement dedupe function

4ee500d

Implement test for dedupe function to handle arrays with no duplicates

6d78cdb

moses77-boop added 15 commits October 23, 2026 16:42

Add tests for calculateMean function to handle non-array inputs

bece9ad

Add input validation to calculateMean function for non-array inputs

c0a278a

Add test for calculateMean function to handle no arguments

0bb1418

Add test for calculateMean function to handle non-number values in array

55521a9

Add input validation for array elements in calculateMean function

cd600e2

Implement test for describeMedian function to validate median calcula…

0ab70f6

…tion

Implement describeMedian function to return median value as a string

3cd3611

Add tests for empty array cases

783326c

Add error handling to describeMedian function for invalid input

b9f0e90

Fix test typo in error message for empty array case

74b3e77

Add test for non-number value of array case in describeMedian and fix…

c08e109

… typo

Fix typo in error message for median calculation failure

435bc33

Refactor includes function to use for...of loop for improved readability

068ad9d

Update input data for aoc-2018-day1 with new values and formatting ad…

3f5b5d3

…justments

Implement frequency calculation logic and handle duplicate frequencies

d1b8c93

moses77-boop added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Oct 23, 2026

Refactor loop structure for improved readability in frequency calcula…

de542e0

…tion

cjyuan reviewed Oct 31, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 31, 2026

moses77-boop added 5 commits October 31, 2026 12:12

Refactor mean test cases for improved readability and consistency

2061fba

Refactor error handling tests for non-array inputs in calculateMean f…

0afbaed

…unction

Refactor formatting for consistency in calculateMean function

ca719e8

Refactor sum function for improved formatting and consistency

5d3b691

Refactor sum test cases for improved readability and consistency

9710b41

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 31, 2026

Conversation

moses77-boop commented Oct 23, 2026

Task code

Changelist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan Oct 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Oct 31, 2026

Uh oh!

cjyuan commented Oct 31, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cjyuan Oct 31, 2026 •

edited

Loading