Repository navigation
fix: images in the Mac app; docs: a screenshot tour of every feature - #15
Merged
Merged
Conversation
The Mac app's content rules blocked the blob: URLs that the image viewer and Markdown previews draw images from, so every image failed with "could not be decoded". One anchored allow rule for blob: on the window's own origin fixes it. Also: .jfif/.jpe/.apng/TIFF/HEIC open as images, an undecodable image falls back to the hex dump, Markdown previews skip images over 20 MB (/api/raw?max=), and the SVG source toggle ignores letter case. The landing page gains "A tour of every feature": 20 features with light and dark screenshots taken by `bun run shots` in a deterministic demo repository (scripts/shots.ts, demo-repo.ts, packaging/macos/appshot.swift). Reviewed for accuracy, visual design/accessibility and security (DESIGN.md round 10). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix: images in the Mac app
Every image (JPEG, PNG, GIF, SVG…) failed in the Mac app with "This image could not be decoded", in the image viewer and in Markdown previews. Images are fetched with the auth header and drawn from
blob:URLs, and the window's content rule list only allowedhttp://andws://on its own port. The fix adds one anchored allow rule forblob:http://127.0.0.1:<port>/; only script on that origin can mint such URLs, and navigation toblob:is still cancelled. Verified with the real rule list compiled into a WKWebView. Linux (Chromium) was not affected.Also:
.jfif,.jpe,.apng, TIFF and HEIC open as images (TIFF/HEIC decode in WebKit)./api/raw?max=Nanswers 413).Landing page: a tour of every feature
srcsethalf-size variants for phones, and copy checked against the source.bun run shotsretakes them reproducibly: a deterministic demo repo, an isolated server/config/HOME/prompt, and an offscreen WKWebView driver (packaging/macos/appshot.swift).Tests
bun run test: 1306 pass, 0 fail. New:test/images.test.ts(formats, server/client lists in sync, the Mac rule set),test/client.imageview.test.ts(hex-dump fallback, SVG toggle case),/api/raw?maxcoverage.🤖 Generated with Claude Code