fix: replace bare except clauses with except Exception (#1190)

Bare `except:` catches BaseException including KeyboardInterrupt and
SystemExit. Replaced 26 instances with `except Exception:`.

Co-authored-by: haosenwang1018 <haosenwang1018@users.noreply.github.com>

Author: haosenwang1018

modules/index_func.py

@@ -32,7 +32,7 @@ def get_documents(file_src):
 
                     two_column = advance_docs["pdf"].get("two_column", False)
                     pdftext = parse_pdf(filepath, two_column).text
-                except:
+                except Exception:
                     pdftext = ""
                     with open(filepath, "rb") as pdfFileObj:
                         pdfReader = PyPDF2.PdfReader(pdfFileObj)

modules/models/GoogleGemma.py

@@ -34,7 +34,7 @@ def __init__(self, model_name, api_key, user_name="") -> None:
                 else:
                     try:
                         model_source = MODEL_METADATA[model_name]["repo_id"]
-                    except:
+                    except Exception:
                         model_source = model_name
             dtype = torch.bfloat16
             GEMMA_TOKENIZER = AutoTokenizer.from_pretrained(

modules/models/OpenAIVision.py

@@ -218,7 +218,7 @@ def _get_response(self, stream=False):
                     stream=stream,
                     timeout=timeout,
                 )
-            except:
+            except Exception:
                 traceback.print_exc()
                 return None
         return response
@@ -256,7 +256,7 @@ def _decode_chat_response(self, response):
                 chunk_length = len(chunk)
                 try:
                     chunk = json.loads(chunk[6:])
-                except:
+                except Exception:
                     print(i18n("JSON解析错误,收到的内容: ") + f"{chunk}")
                     error_msg += chunk
                     continue
@@ -279,7 +279,7 @@ def _decode_chat_response(self, response):
                         except Exception as e:
                             # logging.error(f"Error: {e}")
                             continue
-                except:
+                except Exception:
                     traceback.print_exc()
                     print(f"ERROR: {chunk}")
                     continue

modules/models/base_model.py

@@ -178,7 +178,7 @@ def get_type(cls, model_name: str):
             try:
                 assert MODEL_METADATA[model_name]["multimodal"] == True
                 model_type = ModelType.OpenAIVision
-            except:
+            except Exception:
                 if "instruct" in model_name_lower:
                     model_type = ModelType.OpenAIInstruct
                 elif "vision" in model_name_lower:
@@ -252,7 +252,7 @@ def download(repo_id, filename, retry=10):
             with open("./models/downloaded_models.json", "w") as f:
                 json.dump(downloaded_models, f)
             break
-        except:
+        except Exception:
             print("Error downloading model, retrying...")
             retry -= 1
     if retry == 0:
@@ -1046,7 +1046,7 @@ def load_chat_history(self, new_history_file_path=None):
                             new_history.append(construct_assistant(item))
                     saved_json["history"] = new_history
                     logging.info(new_history)
-            except:
+            except Exception:
                 pass
             if len(saved_json["chatbot"]) < len(saved_json["history"]) // 2:
                 logging.info("Trimming corrupted history...")
@@ -1105,7 +1105,7 @@ def load_chat_history(self, new_history_file_path=None):
                 gr.DownloadButton(value=tmp_json_for_download, interactive=True),
                 gr.DownloadButton(value=tmp_md_for_download, interactive=True),
             )
-        except:
+        except Exception:
             # 没有对话历史或者对话历史解析失败
             logging.debug(f"没有找到对话历史记录 {self.history_file_path}")
             self.reset()
@@ -1152,7 +1152,7 @@ def delete_chat_history(self, filename):
             os.remove(history_file_path)
             os.remove(md_history_file_path)
             return i18n("删除对话历史成功"), get_history_list(self.user_name), []
-        except:
+        except Exception:
             logging.info(f"删除对话历史失败 {history_file_path}")
             return (
                 i18n("对话历史") + filename + i18n("已经被删除啦"),

modules/models/inspurai.py

@@ -201,7 +201,7 @@ def submit_API(self, prompt, trun=[]):
                         txt = txt[:txt.index(tr)]
                     else:
                         continue
-        except:
+        except Exception:
             return txt
         return txt
 

modules/models/minimax.py

@@ -122,7 +122,7 @@ def _get_response(self, stream=False):
                 stream=stream,
                 timeout=timeout,
             )
-        except:
+        except Exception:
             return None
 
         return response

modules/utils.py

@@ -382,7 +382,7 @@ def detect_converted_mark(userinput):  # deprecated
             return True
         else:
             return False
-    except:
+    except Exception:
         return True
 
 
@@ -569,7 +569,7 @@ def filter_history(user_name, keyword):
     try:
         history_names = [name for name in history_names if re.search(keyword, name, timeout=0.01)]
         return gr.update(choices=history_names)
-    except:
+    except Exception:
         return gr.update(choices=history_names)
 
 
@@ -615,7 +615,7 @@ def get_template_content(templates, selection, original_system_prompt):
     logging.debug(f"应用模板中，选择为{selection}，原始系统提示为{original_system_prompt}")
     try:
         return templates[selection]
-    except:
+    except Exception:
         return original_system_prompt
 
 
@@ -691,7 +691,7 @@ def fetch_ip():
             with retrieve_proxy():
                 response = requests.get("https://ipapi.co/json/", timeout=5)
             data = response.json()
-        except:
+        except Exception:
             data = {"error": True, "reason": "连接ipapi失败"}
         if "error" in data.keys():
             # logging.warning(f"无法获取IP地址信息。\n{data}")
@@ -903,7 +903,7 @@ def beautify_err_msg(err_msg):
         return i18n("请查看 config_example.json，配置 Azure OpenAI")
     try:
         err_msg = json.loads(err_msg)["error"]["message"]
-    except:
+    except Exception:
         pass
     return err_msg
 
@@ -1069,7 +1069,7 @@ def set(self, config_items: List[ConfigItem], prompt: str):
                     print(generate_result_string(config_item, config_value))
                     try:
                         self.config[config_item.key] = int(config_value)
-                    except:
+                    except Exception:
                         print("输入的不是数字，将使用默认值。")
                 elif config_item.type == ConfigType.ListOfStrings:
                     # read one string at a time
@@ -1511,42 +1511,42 @@ def setPlaceholder(model_name: str | None = "", model: BaseLLMModel | None = Non
     if model is None:
         try:
             model_logo = MODEL_METADATA[model_name]["placeholder"]["logo"]
-        except:
+        except Exception:
             logo_class = "hideK"
         try:
             model_logo_round = MODEL_METADATA[model_name]["placeholder"]["logo_rounded"]
-        except:
+        except Exception:
             pass
         try:
             model_slogan = i18n(MODEL_METADATA[model_name]["placeholder"]["slogan"])
-        except:
+        except Exception:
             slogan_class = "hideK"
         try:
             model_question_1 = i18n(MODEL_METADATA[model_name]["placeholder"]["question_1"])
             model_question_2 = i18n(MODEL_METADATA[model_name]["placeholder"]["question_2"])
             model_question_3 = i18n(MODEL_METADATA[model_name]["placeholder"]["question_3"])
             model_question_4 = i18n(MODEL_METADATA[model_name]["placeholder"]["question_4"])
-        except:
+        except Exception:
             question_class = "hideK"
     else:
         try:
             model_logo = model.placeholder["logo"]
-        except:
+        except Exception:
             logo_class = "hideK"
         try:
             model_logo_round = model.placeholder["logo_rounded"]
-        except:
+        except Exception:
             pass
         try:
             model_slogan = i18n(model.placeholder["slogan"])
-        except:
+        except Exception:
             slogan_class = "hideK"
         try:
             model_question_1 = i18n(model.placeholder["question_1"])
             model_question_2 = i18n(model.placeholder["question_2"])
             model_question_3 = i18n(model.placeholder["question_3"])
             model_question_4 = i18n(model.placeholder["question_4"])
-        except:
+        except Exception:
             question_class = "hideK"
 
     if logo_class == "hideK" and slogan_class == "hideK" and question_class == "hideK":